Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stale read maybe always blocked cause by ResolvedTS blocked #44990

Closed
crazycs520 opened this issue Jun 27, 2023 · 3 comments
Closed

Stale read maybe always blocked cause by ResolvedTS blocked #44990

crazycs520 opened this issue Jun 27, 2023 · 3 comments
Assignees
@crazycs520
Labels
affects-6.5 affects-7.0 affects-7.1 affects-7.2 severity/critical sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.

Comments

@crazycs520
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. tidb-server config:
[labels]
zone = "z1"

Then stale read request is always not GlobalStaleRead. Then when stale read requests meet DataIsNotReady error, TiDB will retry the next available region replica. But if the ResolvedTS is blocked, the stale read request will always recieve DataIsNotReady error. In this situation, TiDB should send the stale read request to region leader, and remove the request.StaleRead flag, then the region leader can always handle it.

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

tidb v6.5.3
@crazycs520 crazycs520 added the type/enhancement The issue or PR belongs to an enhancement. label Jun 27, 2023
@crazycs520 crazycs520 changed the title Stale read maybe always blocked cause by DataIsNotReady Stale read maybe always blocked cause by ResolvedTS blocked Jun 27, 2023
@tiancaiamao
Copy link
Contributor

This issue should be a bug instead of enhancement? @crazycs520

@tiancaiamao tiancaiamao added the sig/transaction SIG:Transaction label Jun 28, 2023
@crazycs520 crazycs520 self-assigned this Jun 28, 2023
@crazycs520 crazycs520 mentioned this issue Jun 28, 2023
Merged
@cfzjywxk cfzjywxk added type/bug The issue is confirmed as a bug. and removed type/enhancement The issue or PR belongs to an enhancement. labels Jun 28, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Jun 29, 2023
@crazycs520 crazycs520 mentioned this issue Jul 3, 2023
Closed
12 tasks
@crazycs520 crazycs520 removed affects-6.5 may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 labels Jul 3, 2023
@crazycs520 crazycs520 mentioned this issue Jul 11, 2023
Closed
12 tasks
@crazycs520
Copy link
Contributor Author

already fixed.

@crazycs520
Copy link
Contributor Author

release-6.5 already fixed by #46137

@crazycs520 crazycs520 mentioned this issue Aug 16, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crazycs520 crazycs520

Labels
affects-6.5 affects-7.0 affects-7.1 affects-7.2 severity/critical sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: update client-go pkg crazycs520/tidb
4 participants
@tiancaiamao @cfzjywxk @jebter @crazycs520