Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subtask failover shouldn't change state of subtask #47297

Closed
D3Hunter opened this issue Sep 26, 2023 · 2 comments
Closed

subtask failover shouldn't change state of subtask #47297

D3Hunter opened this issue Sep 26, 2023 · 2 comments
Labels
affects-7.5 component/ddl This issue is related to DDL of TiDB. feature/developing the related feature is in development may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 severity/major type/bug The issue is confirmed as a bug.

Comments

@D3Hunter
Copy link
Contributor

D3Hunter commented Sep 26, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

subtask failover shouldn't change state of subtask, we should keep the state, and let scheduler handle it depends on whether the subtask is idempotent(this part will be changed when we fix #46735)

if err := sqlexec.FormatSQL(sql, "update mysql.tidb_background_subtask set state = %? ,exec_id = (case ", proto.TaskStatePending); err != nil {

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master

@D3Hunter D3Hunter added the type/bug The issue is confirmed as a bug. label Sep 26, 2023
@D3Hunter
Copy link
Contributor Author

refer #47298 too

@seiya-annie seiya-annie added severity/major feature/developing the related feature is in development component/ddl This issue is related to DDL of TiDB. labels Sep 26, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Sep 26, 2023
@D3Hunter
Copy link
Contributor Author

currently, we take all subtasks as idempotent and run the failovered subtask again directly, so this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.5 component/ddl This issue is related to DDL of TiDB. feature/developing the related feature is in development may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

3 participants