Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make bazel running without nogo #50400

Closed
hawkingrei opened this issue Jan 14, 2024 · 2 comments · Fixed by #54170
Closed

make bazel running without nogo #50400

hawkingrei opened this issue Jan 14, 2024 · 2 comments · Fixed by #54170
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@hawkingrei
Copy link
Member

hawkingrei commented Jan 14, 2024

Enhancement

With nogo, we can run many linter with cache. but developers run it locally. it still takes too much time. so we need to add a new mode without nogo to build.

@hawkingrei hawkingrei added type/enhancement The issue or PR belongs to an enhancement. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jan 14, 2024
@bhavyastar
Copy link

Hey @hawkingrei , I would like to work on this issue.

@ei-sugimoto
Copy link
Contributor

This problem does not appear to have been solved for a long time. May I tackle it?
Here are my ideas.

...
.PHONY: bazel_lint
NOGO_FLAG=true
bazel_lint: bazel_prepare
    bazel build //... --//build:with_nogo_flag=$(NOGO_FLAG)
...
make NOGO_FLAG=false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants