Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR#53537 caused 20-34% performance regression in oltp_read_only and oltp_read_write #54070

Closed
Yui-Song opened this issue Jun 18, 2024 · 3 comments · Fixed by #54073
Closed

PR#53537 caused 20-34% performance regression in oltp_read_only and oltp_read_write #54070

Yui-Song opened this issue Jun 18, 2024 · 3 comments · Fixed by #54073
Assignees
@xzhangxian1008
Labels
severity/critical sig/execution SIG execution type/bug The issue is confirmed as a bug. type/performance type/regression

Comments

@Yui-Song
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. deploy a cluster with 3 tidb and 3 tikv
  2. run sysbench oltp_read_only and oltp_read_write with pr backup: watch store state and retry backup immediately #53341 and executor: enable parallel sort #53537

2. What did you expect to see? (Required)

No regression.

3. What did you see instead (Required)

PR#53537 caused performance regression in oltp_read_only (34%) and oltp_read_write(20%)
image

4. What is your TiDB version? (Required)

#53537
@Yui-Song Yui-Song added the type/bug The issue is confirmed as a bug. label Jun 18, 2024
@Yui-Song
Copy link
Contributor Author

/type performance
/type regression
/severity critical
/sig execution
/assign @xzhangxian1008

@Yui-Song
Copy link
Contributor Author

/remove-label may-affects-8.1
/remove-label may-affects-7.5
/remove-label may-affects-7.1
/remove-label may-affects-6.5
/remove-label may-affects-6.1
/remove-label may-affects-5.4

@xzhangxian1008 xzhangxian1008 mentioned this issue Jun 18, 2024
Merged
13 tasks
@jebter
Copy link

jebter commented Jun 20, 2024

Releted to issue:#49217

@ti-chi-bot ti-chi-bot bot closed this as completed in bec113a Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xzhangxian1008 xzhangxian1008

Labels
severity/critical sig/execution SIG execution type/bug The issue is confirmed as a bug. type/performance type/regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor: remove redundant memory pre-allocations in parallel sort executor xzhangxian1008/tidb
3 participants
@jebter @xzhangxian1008 @Yui-Song