Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinBitNegSig #13554

Merged
merged 4 commits into from
Nov 19, 2019
Merged

expression: implement vectorized evaluation for builtinBitNegSig #13554

merged 4 commits into from
Nov 19, 2019

Conversation

AerysNan
Copy link
Contributor

PCP #12103

What problem does this PR solve?

Implement vectorized evaluation for builtinBitNegSig

What is changed and how it works?

BenchmarkVectorizedBuiltinOpFunc/builtinBitNegSig-VecBuiltinFunc-56              2170525               602 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinOpFunc/builtinBitNegSig-NonVecBuiltinFunc-56             47398             28934 ns/op               0 B/op          0 allocs/op

Check List

Tests

  • Unit test

@AerysNan AerysNan requested a review from a team as a code owner November 18, 2019 13:16
@sre-bot
Copy link
Contributor

sre-bot commented Nov 18, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 18, 2019
@ghost ghost requested review from SunRunAway and XuHuaiyu and removed request for a team November 18, 2019 13:16
@CLAassistant
Copy link

CLAassistant commented Nov 18, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@AerysNan
add vectorized builtinBitNegSig
7dfe721 
Signed-off-by: AerysNan <aerysnan@gmail.com>
@codecov
Copy link

codecov bot commented Nov 18, 2019 •
edited
Loading

Codecov Report

Merging #13554 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13554   +/-   ##
===========================================
  Coverage   80.5299%   80.5299%           
===========================================
  Files           472        472           
  Lines        116168     116168           
===========================================
  Hits          93550      93550           
  Misses        15355      15355           
  Partials       7263       7263

qw4990
qw4990 reviewed Nov 19, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 19, 2019
@AerysNan AerysNan requested a review from Reminiscent November 19, 2019 04:24
Reminiscent
Reminiscent approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 19, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 19, 2019

Your auto merge job has been accepted, waiting for 13560

@sre-bot
Copy link
Contributor

sre-bot commented Nov 19, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 19, 2019

@AerysNan merge failed.

@AerysNan
Copy link
Contributor Author

@sre-bot /run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 19, 2019

/run-all-tests

@AerysNan
Copy link
Contributor Author

@Reminiscent Automerge failed. Maybe merge it again?

@qw4990
Copy link
Contributor

qw4990 commented Nov 19, 2019

@Reminiscent Automerge failed. Maybe merge it again?

I will merge it manually soon.

@qw4990 qw4990 merged commit ec2d6b7 into pingcap:master Nov 19, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 19, 2019

@AerysNan complete task #12103 and get 50 score, currerent score 150.

@AerysNan AerysNan deleted the vectorize/builtinBitNegSig branch November 22, 2019 05:27
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@AerysNan @XiaTianliang
expression: implement vectorized evaluation for builtinBitNegSig (p…
f114fb0 
…ingcap#13554)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@Reminiscent Reminiscent Reminiscent approved these changes

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AerysNan @sre-bot @CLAassistant @qw4990 @Reminiscent @zz-jason