Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TiUP should serially scale in and scale out PD #1187

Closed
HunDunDM opened this issue Mar 5, 2021 · 3 comments
Closed

TiUP should serially scale in and scale out PD #1187

HunDunDM opened this issue Mar 5, 2021 · 3 comments
Labels
category/stability Categorizes issue or PR as a stability enhancement. type/feature-request Categorizes issue as related to a new feature.

Comments

@HunDunDM
Copy link
Contributor

HunDunDM commented Mar 5, 2021

Feature Request

Is your feature request related to a problem? Please describe:

  • Changing the number of PDs needs to follow the raft process, and only one can be changed at a time. Otherwise, the expanded PD may fail to start.

image

Describe the feature you'd like:

  • TiUP should serially scale in and scale out PD

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

  • Go
@HunDunDM HunDunDM added the type/feature-request Categorizes issue as related to a new feature. label Mar 5, 2021
@AstroProfundis AstroProfundis added the category/stability Categorizes issue or PR as a stability enhancement. label Mar 5, 2021
@9547
Copy link
Contributor

9547 commented Mar 8, 2021

@HunDunDM Could you please provide the instruction and failed logs in detail?

@9547
Copy link
Contributor

9547 commented Mar 27, 2021

I've reproduced this issue. My originally Topology has 3 PDs(all nodes are healthy), and the scale-out topology as below:

pd_servers:
  - host: n6
  - host: n7
  - host: n8
  - host: n9
  - host: n10
  - host: n11
  - host: n12
  - host: n13
  - host: n14
  - host: n15
  - host: n16
  - host: n17
  - host: n18
  - host: n19
  - host: n20

The scale-out failed, message as below:

image

the error log in n9:2379's pd.log:

[2021/03/27 06:42:07.492 +00:00] [FATAL] [main.go:93] ["join meet error"] [error="there is a member that has not joined successfully"] [stack="github.com/pingcap/log.Fatal\n\t/home/jenkins/agent/workspace/build_pd_multi_branch_v4.0.4/go/pkg/mod/github.com/pingcap/log@v0.0.0-20200511115504-543df19646ad/global.go:59\nmain.main\n\t/home/jenkins/agent/workspace/build_pd_multi_branch_v4.0.4/go/src/github.com/pingcap/pd/cmd/pd-server/main.go:93\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:203"]

The cluster display:

image

2/15 nodes scale-out succeed.

@seiya-annie
Copy link

/found customer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/stability Categorizes issue or PR as a stability enhancement. type/feature-request Categorizes issue as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants