Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test cases to avoid panel missing in Grafana #1275

Open
flowbehappy opened this issue Apr 2, 2021 · 1 comment
Open

Test cases to avoid panel missing in Grafana #1275

flowbehappy opened this issue Apr 2, 2021 · 1 comment
Labels
category/testing Categorizes issue or PR as a testing enhancement. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/feature-request Categorizes issue as related to a new feature.

Comments

@flowbehappy
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe:
Like this issue, #1083, tiup's cluster failed to add TiFlash nodes to Grafana's Node_exporter panel. And currently, we don't have test cases to cover this issue.

Describe the feature you'd like:

Test cases that promise we don't lose any components' panels in Grafana.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:
@flowbehappy flowbehappy added the type/feature-request Categorizes issue as related to a new feature. label Apr 2, 2021
@AstroProfundis AstroProfundis added category/testing Categorizes issue or PR as a testing enhancement. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 12, 2021
@AstroProfundis
Copy link
Contributor

Grafana panels are maintained by each component themselves, we need to find a way to know which files are "correct" to be packaged into the tar ball when we publish new releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category/testing Categorizes issue or PR as a testing enhancement. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/feature-request Categorizes issue as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AstroProfundis @flowbehappy