Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiup mandatory scaling needs to add judgment rules #1541

Closed
xiaoyangwang5 opened this issue Aug 31, 2021 · 2 comments
Closed

Tiup mandatory scaling needs to add judgment rules #1541

xiaoyangwang5 opened this issue Aug 31, 2021 · 2 comments
Labels
type/feature-request Categorizes issue as related to a new feature.

Comments

@xiaoyangwang5
Copy link

Feature Request

Is your feature request related to a problem? Please describe:

When a customer expands multiple nodes at the same time and shrinks multiple nodes at the same time, it is easy to use the forced shrinking command, resulting in data loss
Describe the feature you'd like:

tiup forced shrinkage --force parameter, need to judge the label situation, need to have prompt or prohibit function

Why the featue is needed:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@xiaoyangwang5 xiaoyangwang5 added the type/feature-request Categorizes issue as related to a new feature. label Aug 31, 2021
@AstroProfundis
Copy link
Contributor

--force is designed to be unsafe and data loss is expected.

Could you describe more details about the safe process that we might be able to implement on normal scaling operations?

@qqqdan
Copy link
Collaborator

qqqdan commented Jan 18, 2022

We already add more significant warning when --force argument is set for scale-in command in tiup-cluster (#1629, @AstroProfundis)

@qqqdan qqqdan closed this as completed Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature-request Categorizes issue as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants