Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TiUP Playground fails to stop with TiProxy #2317

Closed
dveeden opened this issue Nov 14, 2023 · 2 comments · Fixed by #2318
Closed

TiUP Playground fails to stop with TiProxy #2317

dveeden opened this issue Nov 14, 2023 · 2 comments · Fixed by #2318
Labels
type/bug Categorizes issue as related to a bug.

Comments

@dveeden
Copy link
Contributor

dveeden commented Nov 14, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
tiup playground --tiproxy 1 --tiflash 0 v7.1.2

Then press ^C

  1. What did you expect to see?

TiUP Playground to stop gracefully.

  1. What did you see instead?
$ tiup playground --tiproxy 1 --tiflash 0 v7.1.2
tiup is checking updates for component playground ...
Starting component `playground`: /home/dvaneeden/.tiup/components/playground/v1.13.1/tiup-playground --tiproxy 1 --tiflash 0 v7.1.2
Start pd instance:v7.1.2
Start tikv instance:v7.1.2
Start tidb instance:v7.1.2
Start tiproxy instance:nightly
Waiting for tidb and tiproxy instances ready
127.0.0.1:4000 ... Done
127.0.0.1:6000 ... Done

🎉 TiDB Playground Cluster is started, enjoy!

Connect TiDB:    mysql --comments --host 127.0.0.1 --port 4000 -u root
Connect TiProxy: mysql --comments --host 127.0.0.1 --port 6000 -u root
TiDB Dashboard:  http://127.0.0.1:2379/dashboard
Grafana:        http://127.0.0.1:3000
^CPlayground receive signal:  interrupt
Got signal interrupt (Component: playground ; PID: 476651)
Wait tidb(476697) to quit...
Wait grafana(476922) to quit...
Wait ng-monitoring(476892) to quit...
Wait prometheus(476891) to quit...
Grafana quit
prometheus quit
ng-monitoring quit
tidb quit
Wait tikv(476681) to quit...
tikv quit
Wait pd(476667) to quit...
pd quit

(and not getting my prompt back)

$ pstree -aTp 476638
tiup,476638 playground --tiproxy 1 --tiflash 0 v7.1.2
  └─tiup-playground,476651 --tiproxy 1 --tiflash 0 v7.1.2
      └─tiproxy,476708 --config=/home/dvaneeden/.tiup/data/TvZy32y/tiproxy-0/config/proxy.toml
  1. What version of TiUP are you using (tiup --version)?
1.13.1 tiup
Go Version: go1.21.1
Git Ref: v1.13.1
GitHash: 3653dc521afbd0da505cdbe4bcbc92c39fe66b74

Related #2202

@dveeden dveeden added the type/bug Categorizes issue as related to a bug. label Nov 14, 2023
@dveeden
Copy link
Contributor Author

dveeden commented Nov 14, 2023

/component playground

@dveeden
Copy link
Contributor Author

dveeden commented Nov 14, 2023

Sending a SIGTERM to the pid of tiproxy works. So it seems like playground doesn't do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Categorizes issue as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant