Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiup cluster upgrade config check failed #598

Closed
cyliu0 opened this issue Jul 10, 2020 · 3 comments · Fixed by pingcap/tidb#18618
Closed

tiup cluster upgrade config check failed #598

cyliu0 opened this issue Jul 10, 2020 · 3 comments · Fixed by pingcap/tidb#18618
Labels
type/bug Categorizes issue as related to a bug.

Comments

@cyliu0
Copy link

cyliu0 commented Jul 10, 2020

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?

Deploy and start a v4.0.1 cluster with config experimental.allow-auto-random = true
tiup cluster upgrade $cluster_name nightly

tidb has removed the configuration on master.

Workaround: Use cluster edit-config remove the configuration and then upgrade.

  1. What did you expect to see?
    Upgrade successfully

  2. What did you see instead?
    Upgrade failed because of tidb-server config check failed

  3. What version of TiUP are you using (tiup --version)?
    1.0.7

@cyliu0 cyliu0 added the type/bug Categorizes issue as related to a bug. label Jul 10, 2020
@lonng
Copy link
Contributor

lonng commented Jul 12, 2020

The TiUP won't guarantee all configuration user-configured valid, all configuration will be converted to the toml format directly.

@cyliu0
Copy link
Author

cyliu0 commented Jul 14, 2020

How did we deal with a situation like this during the past? The components may abandon some configurations occasionally. And if we do not have a solution for this inside tiup or the components, maybe it will bring a lot of OnCall cases or upgrade document work.

@lonng
Copy link
Contributor

lonng commented Jul 14, 2020

The components have changed the behaviors of treating abandoned configurations, print some warnings instead of panic, this rule can be applied to >= 4.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Categorizes issue as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants