Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring the function readDirectory() and the function traverseFileTree() #22

Open
pinglu85 opened this issue Apr 28, 2021 · 0 comments
Open

Refactoring the function readDirectory() and the function traverseFileTree() #22

pinglu85 opened this issue Apr 28, 2021 · 0 comments
Assignees
@pinglu85
Labels
refactor Refactoring production code

Comments

@pinglu85
Copy link
Owner

  • Use more descriptive function names.
  • Convert traverseFileTree() into our actual recursive function.
  • Test if we could remove the readNextEntries() function call in reader.readEntries().
@pinglu85 pinglu85 self-assigned this Apr 28, 2021
@pinglu85 pinglu85 added the refactor Refactoring production code label Apr 28, 2021
@pinglu85 pinglu85 changed the title Refactor the function readDirectory() and the function traverseFileTree() Refactoring the function readDirectory() and the function traverseFileTree() Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinglu85 pinglu85

Labels
refactor Refactoring production code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pinglu85