-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transpose of pattern fallthrough #1
Comments
Next after this is to plan which issues will and won't make the cut for wip11. These are my tentative top three: - #1: Transpose of fallthrough (reported by #jroatch) It's always nice to try addressing the oldest issue on record. - #36: ft2pently example (requested by @adrian0901) More people appear to prefer the tracker route. Make that easy. - #2: Document reentrancy Many devs swear by calling the sound driver from the NMI handler in order to keep music from lagging even when the game lags. I'm not in that habit because of data races and stateful mappers (MMC1, MMC3, FME-7). So I'll show my catch-up workaround.
The score could play a fallthrough group starting at any pattern boundary, and
|
I finally started working on #1. I'll start with some changes to find_transpose_runs that the new functionality will need. - Add a docstring - Save both ends of range: highest and lowest semitone
continuing #1: - calculate transpose runs and save them in pattern object - separate pattern transpose from start of 1st run - if 1st run won't fit in pattern transpose, add an initial TRANSPOSE
The test case attached to #1 shows not only the problem with fallthrough (the genuine topic of the issue) but also a quirk where the parser assumes that a pickup belongs to the pattern, not the song. Document this quirk.
This does most of #1, except for stitching the last pattern's pitch range to those of earlier patterns. Also document the fallthrough command and list the commands that close a pattern.
There was a minor problem with the test case that jroatch provided. When I added bar check about two years after the test case (#26), the |
As of 0.05wip3,
pentlyas
supports an undocumentedfallthrough
command, allowing a pattern to continue into the next pattern. But this is defective because it doesn't take into account differences in the transposition base between patterns. @jroatch has provided a test case, with the following explanation:2016-02-03_fallthrough-tests.pently.zip
The text was updated successfully, but these errors were encountered: