Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bar checks to patterns #26

Closed
pinobatch opened this issue Jan 8, 2018 · 1 comment
Closed

Add bar checks to patterns #26

pinobatch opened this issue Jan 8, 2018 · 1 comment

Comments

@pinobatch
Copy link
Owner

LilyPond has a rhythm error detection feature called bar check. Its | command emits a diagnostic if the musical time so far is not a multiple of one measure as defined in a song's time signature.

Like a song (see pickup command), a pattern in Pently may have a pickup, or part that starts unaligned with a bar line. Thus a pattern's first bar check would establish the amount of pickup instead of emitting a diagnostic.

Because a pattern can be defined outside a song, test cases will need to verify that setting a time signature outside a song works:

  • time and scale within a pattern should set the pattern's own rhythm context.
  • time and scale at score level (outside a song) should set the rhythm context for following score-level patterns.
@pinobatch
Copy link
Owner Author

I decided against the "pattern's first bar check sets pickup" rule, instead overloading the pickup keyword to apply to an open pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant