-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests failing in v4.17.5 #16
Comments
But the test isn't broken. It explicitly looks for the |
Hey folks, is someone looking at this or shall I pick it up? I wasn't aware of the integration suite when I was creating my PR 🤦♂️
Any other suggestions? |
If you update your fix it will be a major - which is fine because we are close to releasing v5 - see the next-major branch However for v4 it can't be an update so we need to change the expectation in pino-pretty Please feel free to PR! @mcollina do you concur |
due to pinojs/pino#456
it should be fine to fix the pino-pretty test
cc @mcollina @jsumners
The text was updated successfully, but these errors were encountered: