Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nestedKey support for chindings #762

Closed
rjharmon opened this issue Jan 25, 2020 · 2 comments
Closed

nestedKey support for chindings #762

rjharmon opened this issue Jan 25, 2020 · 2 comments

Comments

@rjharmon
Copy link

rjharmon commented Jan 25, 2020

nestedKey (see #759) seems useful enough in concept to warrant a specialized implementation to support it for log attributes added as part of child-logger creation.

Perhaps it could use a special string-building implementation that concatenates the stringified chindings into [nestedKey] during childLogger.<logLevel>({attrs}, ...) (something like {[nestedKey]: {...chindings, ...attrs}} would do if they were objects).

(Alternatively, it could be worth considering placing existing metadata into {meta: {...}}, such that Pino owns the object in meta:, and loggers & child-loggers can own the remainder of top-level namespace)

@matthewadams thoughts? (also: thanks!)

@rjharmon rjharmon changed the title nestedKeys support for chindings nestedKey support for chindings Jan 25, 2020
@Fdawgs
Copy link
Member

Fdawgs commented May 29, 2023

@rjharmon Did you manage to resolve this?

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants