From 2cc06276a44e4a8804fb4f9513e471a26a7708e2 Mon Sep 17 00:00:00 2001 From: Jaehong-Kim Date: Mon, 23 Oct 2023 17:34:37 +0900 Subject: [PATCH] [#noissue] fix plugin-it engine discover --- .../junit5/engine/PluginTestEngine.java | 34 +++++++++++-------- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/test/src/main/java/com/navercorp/pinpoint/test/plugin/junit5/engine/PluginTestEngine.java b/test/src/main/java/com/navercorp/pinpoint/test/plugin/junit5/engine/PluginTestEngine.java index 5a955cfac67d..7a42442ddd80 100644 --- a/test/src/main/java/com/navercorp/pinpoint/test/plugin/junit5/engine/PluginTestEngine.java +++ b/test/src/main/java/com/navercorp/pinpoint/test/plugin/junit5/engine/PluginTestEngine.java @@ -94,23 +94,29 @@ public TestDescriptor discover(EngineDiscoveryRequest discoveryRequest, UniqueId // Plugin IT List removedTestDescriptorList = new ArrayList<>(); List pluginTestDescriptorList = new ArrayList<>(); - for (TestDescriptor testDescriptor : engineDescriptor.getChildren()) { - if (testDescriptor instanceof ClassTestDescriptor) { - final Class testClass = ((ClassTestDescriptor) testDescriptor).getTestClass(); - TestDescriptor pluginTestDescriptor = null; - if (isTestClassWithPluginTest.test(testClass)) { - pluginTestDescriptor = addPluginTestDescriptor(testDescriptor, configuration); - } else if (isTestClassWithPluginForkedTest.test(testClass)) { - pluginTestDescriptor = addPluginForkedTestDescriptor(testDescriptor, configuration); - } else if (isTestClassWithJunitAgent.test(testClass)) { - pluginTestDescriptor = addPluginJunitTestDescriptor(testDescriptor, configuration); - } - if (pluginTestDescriptor != null) { - pluginTestDescriptorList.add(pluginTestDescriptor); - removedTestDescriptorList.add(testDescriptor); + try { + for (TestDescriptor testDescriptor : engineDescriptor.getChildren()) { + if (testDescriptor instanceof ClassTestDescriptor) { + final Class testClass = ((ClassTestDescriptor) testDescriptor).getTestClass(); + TestDescriptor pluginTestDescriptor = null; + if (isTestClassWithPluginTest.test(testClass)) { + pluginTestDescriptor = addPluginTestDescriptor(testDescriptor, configuration); + } else if (isTestClassWithPluginForkedTest.test(testClass)) { + pluginTestDescriptor = addPluginForkedTestDescriptor(testDescriptor, configuration); + } else if (isTestClassWithJunitAgent.test(testClass)) { + pluginTestDescriptor = addPluginJunitTestDescriptor(testDescriptor, configuration); + } + + if (pluginTestDescriptor != null) { + pluginTestDescriptorList.add(pluginTestDescriptor); + removedTestDescriptorList.add(testDescriptor); + } } } + } catch (Exception e) { + System.out.println("Failed to discover"); + e.printStackTrace(); } for (TestDescriptor removedTestDescriptor : removedTestDescriptorList) {