From 6fc121899d97300ca679153d4fb60978097dbdb3 Mon Sep 17 00:00:00 2001 From: seoyoung-park Date: Mon, 16 Oct 2023 16:49:19 +0900 Subject: [PATCH] [#9631] Limit length of stackTrace strings for better stability --- .../exceptiontrace/web/mapper/StackTraceMapper.java | 10 +++++++--- .../exceptiontrace/web/util/GroupByAttributes.java | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/exceptiontrace/exceptiontrace-web/src/main/java/com/navercorp/pinpoint/exceptiontrace/web/mapper/StackTraceMapper.java b/exceptiontrace/exceptiontrace-web/src/main/java/com/navercorp/pinpoint/exceptiontrace/web/mapper/StackTraceMapper.java index 094dd188d2e1..a9188d734858 100644 --- a/exceptiontrace/exceptiontrace-web/src/main/java/com/navercorp/pinpoint/exceptiontrace/web/mapper/StackTraceMapper.java +++ b/exceptiontrace/exceptiontrace-web/src/main/java/com/navercorp/pinpoint/exceptiontrace/web/mapper/StackTraceMapper.java @@ -16,6 +16,7 @@ package com.navercorp.pinpoint.exceptiontrace.web.mapper; import com.navercorp.pinpoint.common.server.mapper.MapStructUtils; +import com.navercorp.pinpoint.common.util.StringUtils; import com.navercorp.pinpoint.exceptiontrace.common.model.StackTraceElementWrapper; import com.navercorp.pinpoint.exceptiontrace.web.entity.ExceptionMetaDataEntity; import org.mapstruct.Qualifier; @@ -58,14 +59,17 @@ public List stackTrace(ExceptionMetaDataEntity entity) for (int i = 0; i < classNameIterable.size(); i++) { wrappers.add( new StackTraceElementWrapper( - classNameIterable.get(i), - fileNameIterable.get(i), + abbreviate(classNameIterable.get(i)), + abbreviate(fileNameIterable.get(i)), lineNumberIterable.get(i), - methodNameIterable.get(i) + abbreviate(methodNameIterable.get(i)) ) ); } return wrappers; } + private static String abbreviate(String str) { + return StringUtils.abbreviate(str, 2048); + } } diff --git a/exceptiontrace/exceptiontrace-web/src/main/java/com/navercorp/pinpoint/exceptiontrace/web/util/GroupByAttributes.java b/exceptiontrace/exceptiontrace-web/src/main/java/com/navercorp/pinpoint/exceptiontrace/web/util/GroupByAttributes.java index 6899e093bb9d..b9ea4e341e00 100644 --- a/exceptiontrace/exceptiontrace-web/src/main/java/com/navercorp/pinpoint/exceptiontrace/web/util/GroupByAttributes.java +++ b/exceptiontrace/exceptiontrace-web/src/main/java/com/navercorp/pinpoint/exceptiontrace/web/util/GroupByAttributes.java @@ -23,7 +23,7 @@ */ public enum GroupByAttributes { ERROR_MESSAGE("errorMessage", PinotColumns.ERROR_MESSAGE), - TIMESTMAP("timestamp", PinotColumns.TIMESTAMP), + ERROR_CLASS_NAME("errorClassName", PinotColumns.ERROR_CLASS_NAME), STACK_TRACE("stackTrace", PinotColumns.STACK_TRACE_HASH), URI_TEMPLATE("uriTemplate", PinotColumns.URI_TEMPLATE);