From 7f254c186666a270b51be2ea517bdc83cd13ace1 Mon Sep 17 00:00:00 2001 From: Seoyoung Park Date: Thu, 4 Apr 2024 13:11:50 +0900 Subject: [PATCH] [#noissue] Cleanup --- .../collector/dao/PinotExceptionTraceDao.java | 10 ++++++++-- .../web/model/ExceptionTraceValueViewTest.java | 10 ++++------ 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/exceptiontrace/exceptiontrace-collector/src/main/java/com/navercorp/pinpoint/exceptiontrace/collector/dao/PinotExceptionTraceDao.java b/exceptiontrace/exceptiontrace-collector/src/main/java/com/navercorp/pinpoint/exceptiontrace/collector/dao/PinotExceptionTraceDao.java index 7b730f8073f8..7bf07d44a2d3 100644 --- a/exceptiontrace/exceptiontrace-collector/src/main/java/com/navercorp/pinpoint/exceptiontrace/collector/dao/PinotExceptionTraceDao.java +++ b/exceptiontrace/exceptiontrace-collector/src/main/java/com/navercorp/pinpoint/exceptiontrace/collector/dao/PinotExceptionTraceDao.java @@ -40,6 +40,7 @@ @Repository public class PinotExceptionTraceDao implements ExceptionTraceDao { private final Logger logger = LogManager.getLogger(this.getClass()); + private final boolean isDebugEnabled = logger.isDebugEnabled(); private final KafkaTemplate kafkaExceptionMetaDataTemplate; @@ -64,11 +65,16 @@ public PinotExceptionTraceDao( @Override public void insert(List exceptionMetaData) { Objects.requireNonNull(exceptionMetaData); - logger.info("Pinot data insert: {}", exceptionMetaData); + + if (isDebugEnabled) { + logger.debug("Pinot data insert: {}", exceptionMetaData); + } for (ExceptionMetaData e : exceptionMetaData) { ExceptionMetaDataEntity dataEntity = mapper.toEntity(e); - logger.info("data insert {}", dataEntity); + if (isDebugEnabled) { + logger.debug("data insert {}", dataEntity); + } CompletableFuture> response = this.kafkaExceptionMetaDataTemplate.send( topic, dataEntity ); diff --git a/exceptiontrace/exceptiontrace-web/src/test/java/com/navercorp/pinpoint/exceptiontrace/web/model/ExceptionTraceValueViewTest.java b/exceptiontrace/exceptiontrace-web/src/test/java/com/navercorp/pinpoint/exceptiontrace/web/model/ExceptionTraceValueViewTest.java index d80a138a59ec..bfa562bd3965 100644 --- a/exceptiontrace/exceptiontrace-web/src/test/java/com/navercorp/pinpoint/exceptiontrace/web/model/ExceptionTraceValueViewTest.java +++ b/exceptiontrace/exceptiontrace-web/src/test/java/com/navercorp/pinpoint/exceptiontrace/web/model/ExceptionTraceValueViewTest.java @@ -16,23 +16,21 @@ void testGetFieldName() { GroupedFieldName emptyFieldName = new GroupedFieldName(); emptyFieldName.setErrorMessage(""); view.setGroupedFieldName(emptyFieldName); - assertEquals(ExceptionTraceValueView.EMPTY_STRING, view.getFieldName()); + GroupedFieldName nullStringFieldName = new GroupedFieldName(); - emptyFieldName.setErrorMessage("null"); - view.setGroupedFieldName(emptyFieldName); + nullStringFieldName.setErrorMessage("null"); + view.setGroupedFieldName(nullStringFieldName); + assertEquals("null", view.getFieldName()); - assertEquals(ExceptionTraceValueView.EMPTY_STRING, view.getFieldName()); GroupedFieldName nullFieldName = new GroupedFieldName(); view.setGroupedFieldName(nullFieldName); - assertEquals(ExceptionTraceValueView.TOTAL_FIELDNAME, view.getFieldName()); view.setGroupedFieldName(null); - assertEquals(ExceptionTraceValueView.TOTAL_FIELDNAME, view.getFieldName()); } } \ No newline at end of file