Handle conflicts like private within Java generated models

[ay8s]

No description provided.

[NightlyNexus]

Yep, Java keywords can end up in the generated code if they are keys in the JSON scheme, unfortunately.

Since the Java support currently uses Gson, we could do @SerializedName("private") final MyType nonconflicting_private, but I don't know what to name the generated field.
Any ideas?

[maicki]

We may should introduce some way to overwrite the property name which maps over to the property name. We already do something similar (automatic) with properties on Objective-C side I think.

cc @rahul-malik ^ Any thoughts?

[rahul-malik]

Right now we have a list of reserved words that will get modified to avoid compilation errors. It's specific for objc but we should probably have a list for all languages

[rahul-malik]

@maicki - Tricky part with remapping variable names is things like the interop that we want to have between things like Flow <-> ObjC/Java. I believe we'd want the same name substitutions to apply in all languages which means our list would be the union of all reserved keywords in supported languages.

[rahul-malik]

@maicki @NightlyNexus @ay8s - This change just landed which will rewrite reserved words for the Java output. #187