Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint/go errors #4566

Open
kentakozuka opened this issue Aug 25, 2023 · 3 comments
Open

Fix lint/go errors #4566

kentakozuka opened this issue Aug 25, 2023 · 3 comments
Labels
good first issue Good for newcomers kind/bug Something isn't working

Comments

@kentakozuka
Copy link
Member

What happened:

A Command make lint/go returns many errors.

What you expected to happen:

How to reproduce it:

Environment:

  • piped version:
  • control-plane version:
  • Others:
@karamaru-alpha
Copy link
Contributor

I'd like to take up this issue :)
I plan to resolve all lint errors and Integrate golangci-lint into GitHub Actions.

@khanhtc1202
Copy link
Member

Todo:

  • Confirm make lint/go return no error
  • Update CI to use make lint/go probably

@dgannon991
Copy link
Contributor

dgannon991 commented Mar 29, 2024

I've just had a quick run locally, and there are quite a few issues still present (17 stylecheck, 4 unparam, 4 ineffassign, 8 gocritic) so I'll hop onto this one next, as I'd like to get a bit more familiar with the go code :)
Just a quick check on this one actually, is pkg/app/pipedv1 still in use? Just because there also seems to be a pkg/app/piped? Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants