Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't delete the resources when enabling the prune option in K8S_PRIMARY_ROLLOUT after deleting the manifests #4933

Open
ffjlabo opened this issue May 31, 2024 · 1 comment
Assignees
Labels
kind/bug Something isn't working

Comments

@ffjlabo
Copy link
Member

ffjlabo commented May 31, 2024

What happened:

When I use the PipelineSync, including K8S_PRIMARY_ROLLOUT, sometimes the pruning doesn't work.

What you expected to happen:

It would be nice to delete resources when enabling the prune option in K8S_PRIMARY_ROLLOUT after deleting the manifests.

How to reproduce it:

Using the config below, do the step-by-step instructions.

1. Delete target manifests
Deelte_deploymnt_by_ffjlabo_·_Pull_Request__92_·_ca-dp_ffjlabo-dev

2. set prune: true for the K8S_PRIMARY_ROLLOUT stage
add_prune_option_by_ffjlabo_·_Pull_Request__93_·_ca-dp_ffjlabo-dev

3. re PipelineSync
pruning is working but don't detect the diff with the livestate.
PipeCD


refecence

app.pipecd.yaml
apiVersion: pipecd.dev/v1beta1
kind: KubernetesApp
spec:
  name: canary
  labels:
    env: example
    team: product
  planner:
    alwaysUsePipeline: true
  pipeline:
    stages:
      # Deploy the workloads of CANARY variant. In this case, the number of
      # workload replicas of CANARY variant is 10% of the replicas number of PRIMARY variant.
      - name: K8S_CANARY_ROLLOUT
        with:
          replicas: 10%
      # Wait 10 seconds before going to the next stage.
      - name: WAIT
        with:
          duration: 10s
      # Update the workload of PRIMARY variant to the new version.
      - name: K8S_PRIMARY_ROLLOUT
        with:
          prune: true
      # Destroy all workloads of CANARY variant.
      - name: K8S_CANARY_CLEAN
  description: |
    This app demonstrates how to deploy a Kubernetes app by Canary strategy without requering any mesh.\
    References: [adding a new app](https://pipecd.dev/docs/user-guide/managing-application/adding-an-application/), [app configuration](https://pipecd.dev/docs/user-guide/configuration-reference/)

target resource

- deployment

Environment:

  • piped version:
  • control-plane version:
  • Others:
@ffjlabo ffjlabo added the kind/bug Something isn't working label May 31, 2024
@ffjlabo ffjlabo changed the title can't delete the resources when enabling the prune option in K8S_PRIMARY_ROLLOUT after deleting the manifests Can't delete the resources when enabling the prune option in K8S_PRIMARY_ROLLOUT after deleting the manifests May 31, 2024
@ffjlabo ffjlabo self-assigned this May 31, 2024
@ffjlabo
Copy link
Member Author

ffjlabo commented Jun 21, 2024

Workaround to delete resources

  • do QuickSync with prune: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: 📋 New
Development

No branches or pull requests

1 participant