Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Config appears even after fixing the config. #5032

Closed
t-kikuc opened this issue Jul 11, 2024 · 2 comments
Closed

Invalid Config appears even after fixing the config. #5032

t-kikuc opened this issue Jul 11, 2024 · 2 comments
Labels
kind/bug Something isn't working

Comments

@t-kikuc
Copy link
Member

t-kikuc commented Jul 11, 2024

What happened:

  • Invalid Config kept showing on the console even after fixing the config for ECSApp.

What you expected to happen:

  • InvalidConfig disappeared after fixing the config.

How to reproduce it:

  1. Register an application and deploy it.
  2. Push invalid config to my remote repo.
  3. Invalid Config appears.
  4. Fix the config.
  5. Invalid Config appears.

Environment:

  • piped version: v0.48.0
  • control-plane version: v0.48.0
  • Others: -

Investigation Result

This problem will happen in ECSApp and LambdaApp.

Current Workaround

You need to re-register your application.

The cause

  • Piped reports SyncState(such as Invalid Config) when checking repos, drift detection, and so on.
  • Overwriting Invalid Config requires DriftDetection, but it's not supported yet for ECS and Lambda.

The solution

We need to release DriftDetection for ECS and Lambda.

@t-kikuc t-kikuc added the kind/bug Something isn't working label Jul 11, 2024
@t-kikuc
Copy link
Member Author

t-kikuc commented Aug 14, 2024

Probably this PR will solve that.
#5122

@t-kikuc
Copy link
Member Author

t-kikuc commented Sep 12, 2024

Since #5122 is merged, this will not happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant