Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated model.Deployment.version #5061

Open
khanhtc1202 opened this issue Jul 20, 2024 · 2 comments
Open

Remove deprecated model.Deployment.version #5061

khanhtc1202 opened this issue Jul 20, 2024 · 2 comments
Labels
area/server area/web good first issue Good for newcomers kind/deprecation

Comments

@khanhtc1202
Copy link
Member

What would you like to be added:

model.Deployment.version is deprecated and should be removed.
ref: https://github.com/pipe-cd/pipecd/blob/master/pkg/model/deployment.proto#L86-L87

Why is this needed:
@t-kikuc
Copy link
Member

t-kikuc commented Jul 20, 2024

@khanhtc1202
the same as #3350??

@khanhtc1202
Copy link
Member Author

@t-kikuc ah it's right. Let's me close the older one 👌

@t-kikuc t-kikuc changed the title Remove model.Deployment.version Remove deprecated model.Deployment.version Oct 4, 2024
@t-kikuc t-kikuc added kind/deprecation and removed kind/enhancement New feature or request labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/server area/web good first issue Good for newcomers kind/deprecation
Projects
ROADMAP
Status: 📋 New
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khanhtc1202 @t-kikuc