a test is flaky in pipedv1/controller/planner_test.go

[t-kikuc]

What happened:

• pipecd/pkg/app/pipedv1/controller/planner_test.go

  Lines 455 to 456 in 3d4bd4f

  	name: "multi plugins multi rollback",
  	plugins: []pluginapi.PluginClient{

  seems a flaky test.

What you expected to happen:

• not flaky

How to reproduce it:

Retry the test again and again.

Environment:

• piped version: N/A
• control-plane version: N/A
• Others: reproduced in 3d4bd4f

log:

$ go test ./pkg/app/pipedv1/controller/ -count=1 
ok      github.com/pipe-cd/pipecd/pkg/app/pipedv1/controller     0.250s

$ go test ./pkg/app/pipedv1/controller/ -count=1
ok      github.com/pipe-cd/pipecd/pkg/app/pipedv1/controller     0.246s

$ go test ./pkg/app/pipedv1/controller/ -count=1
ok      github.com/pipe-cd/pipecd/pkg/app/pipedv1/controller     0.251s

$ go test ./pkg/app/pipedv1/controller/ -count=1
--- FAIL: TestBuildPipelineSyncStages (0.00s)
    --- FAIL: TestBuildPipelineSyncStages/multi_plugins_multi_rollback (0.00s)
        planner_test.go:583: 
                Error Trace:    /Users/xxx/pipecd/upstream/pipecd/pkg/app/pipedv1/controller/planner_test.go:583
                Error:          Not equal: 
                                expected: []*model.PipelineStage{(*model.PipelineStage)(0x14000121200), (*model.PipelineStage)(0x140001212c0), (*model.PipelineStage)(0x14000121380), (*model.PipelineStage)(0x14000121440), (*model.PipelineStage)(0x14000121500), (*model.PipelineStage)(0x140001215c0)}
                                actual  : []*model.PipelineStage{(*model.PipelineStage)(0x140001206c0), (*model.PipelineStage)(0x14000120780), (*model.PipelineStage)(0x140001209c0), (*model.PipelineStage)(0x14000120840), (*model.PipelineStage)(0x14000120a80), (*model.PipelineStage)(0x14000120900)}
                            
                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -127,4 +127,4 @@
                                   unknownFields: ([]uint8) <nil>,
                                -  Id: (string) (len=17) "plugin-1-rollback",
                                -  Name: (string) (len=17) "plugin-1-rollback",
                                +  Id: (string) (len=17) "plugin-2-rollback",
                                +  Name: (string) (len=17) "plugin-2-rollback",
                                   Desc: (string) "",
                                @@ -154,4 +154,4 @@
                                   unknownFields: ([]uint8) <nil>,
                                -  Id: (string) (len=17) "plugin-2-rollback",
                                -  Name: (string) (len=17) "plugin-2-rollback",
                                +  Id: (string) (len=17) "plugin-1-rollback",
                                +  Name: (string) (len=17) "plugin-1-rollback",
                                   Desc: (string) "",
                Test:           TestBuildPipelineSyncStages/multi_plugins_multi_rollback
FAIL
FAIL    github.com/pipe-cd/pipecd/pkg/app/pipedv1/controller     0.248s
FAIL