Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed to certainly store the metadata in graceful shutdown #5461

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Dec 27, 2024

What this PR does:

as title.

Why we need it:

Currently, the Wait stage waits for the whole duration AGAIN after graceful shutdown.
That's because graceful shutdown cannot store startTime to Control Plane.

Before fix (wait 1m again after restarting):
image

After fix (wait ends soon after restarting):
image

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc t-kikuc added the kind/bug Something isn't working label Dec 27, 2024
Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-kikuc t-kikuc enabled auto-merge (squash) December 27, 2024 05:21
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 26.14%. Comparing base (6e98705) to head (1e63f1f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/piped/executor/wait/wait.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5461      +/-   ##
==========================================
- Coverage   26.14%   26.14%   -0.01%     
==========================================
  Files         457      457              
  Lines       49107    49107              
==========================================
- Hits        12841    12837       -4     
- Misses      35244    35247       +3     
- Partials     1022     1023       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t-kikuc t-kikuc merged commit 77664e1 into master Dec 27, 2024
16 of 18 checks passed
@t-kikuc t-kikuc deleted the fix-wait-metadata branch December 27, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants