Some callbacks not invoked in call replace in PJSUA2 #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Better to change the sample pjsua2_demo to use the new callback onCallReplaceRequest() instead. |
1 similar comment
|
Better to change the sample pjsua2_demo to use the new callback onCallReplaceRequest() instead. |
…should follow the spec) in call transfer request.
…s Account should be the same as the replaced-call's account, but just found that the PJSUA is not inline with the spec. Update behavior of incoming call replace, the new call should use the same account as the replaced call. Warning: potential backward incompatibility issue, previously the replacing call can use any account (selected using pjsua_acc_find_for_incoming() and app may override via callback), now it is forced to use the same account. Pro: this may maintain the call environments including security level, simpler handling in PJSUA2. Cons: app no longer has control to select the account. Also note that the call transfer also forcefully use the same account as the original one.
sauwming
approved these changes
Apr 13, 2022
trengginas
approved these changes
Apr 26, 2022
arunmitel
pushed a commit
to mitel-networks/pjproject
that referenced
this pull request
Aug 17, 2022
Warning: potential backward incompatibility issue, previously the replacing call can use any account (selected using pjsua_acc_find_for_incoming() and app may override via callback), now it is forced to use the same account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in call replace scenario, the new PJSUA2 Call instance can only be created in
onCallReplaced()callback, which cause application to miss some callbacks such asonCallSdpCreated()andonCreateMediaTransport(). This PR allows application to create the new Call instance earlier, i.e: inonCallReplaceRequest(), so it won't miss theonCallSdpCreated()&onCreateMediaTransport()callbacks.Thanks to Johannes Westhuis for the report.
Note: this PR also bumps up log level of some warnings from 4 to 3 (when app does not create a new Call instance for call transfer & replace).