Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage/implementation of $urlLocaleForPage at the PKPRouter::url() #10242

Open
jonasraoni opened this issue Jul 23, 2024 · 2 comments
Open
Assignees
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone

Comments

@jonasraoni
Copy link
Contributor

Describe the bug
On the PR #9628 a parameter called $urlLocaleForPage was introduced, but in a couple of places its usage seems to be incorrect or missing something, it's needed to review and apply fixes.

For example, the PKPRouter doesn't have the argument $urlLocaleForPage, but it's being used here:

$url = fn (string $locale = ''): string => $router->url($request, null, $page, $op, $path, urlLocaleForPage: $locale);

What application are you using?
OJS 3.5

@jonasraoni jonasraoni added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Jul 23, 2024
@jonasraoni jonasraoni added this to the 3.5 Internal milestone Jul 23, 2024
@asmecher
Copy link
Member

@ajnyga, heads-up: this is related to #699

@ajnyga ajnyga self-assigned this Aug 2, 2024
@ajnyga
Copy link
Collaborator

ajnyga commented Aug 2, 2024

Thanks, tagging @jyhein here since I can not assign him directly,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Development

No branches or pull requests

3 participants