Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider converting UI Library to Storybook #4640

Closed
NateWr opened this issue Mar 28, 2019 · 1 comment
Closed

Consider converting UI Library to Storybook #4640

NateWr opened this issue Mar 28, 2019 · 1 comment
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.

Comments

@NateWr
Copy link
Contributor

NateWr commented Mar 28, 2019

When we started with the UI Library, Storybook still didn't support Vue.js very well. Storybook v5.0 is out now and seems to have better support.

Maintenance of the UI Library is tedious and we'd get a lot of mileage from using a more standardized toolset. If we can properly document our components, and host the library easily, we should switch to it.
@NateWr NateWr added the Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. label Mar 28, 2019
@NateWr
Copy link
Contributor Author

NateWr commented May 13, 2020

Changes introduced in #5865 considerably simplify how components are previewed in the UI Library. Given Storybook's known issues with the Vue.js dev tools, I don't think it's a good idea to convert it to Storybook.

@NateWr NateWr closed this as completed May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NateWr