Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OJS] KeywordCloudPlugin to 3.2 Version of OJS _cache miss not working anymore #5891

Closed
prestesmatheus0 opened this issue May 18, 2020 · 3 comments

Comments

@prestesmatheus0
Copy link

Hello, we were adapting the KeywordCloudPlugin and the function _cacheMiss does not working anymore. Can someone help us to identify something has changed of OJS 3.1 in relation to 3.2 version?
Here the original code that works fine on version 3.1:
https://github.com/lepidus/ojs3-keywordcloud-plugin/blob/master/KeywordCloudBlockPlugin.inc.php#L76
And that is the code with our modifies, in this case, the funciont _cacheMiss doesn’t works:
https://github.com/matheuslepidus/ojs3-keywordcloud-plugin/blob/ojs3.2/KeywordCloudBlockPlugin.inc.php#L77

Thanksss!

@prestesmatheus0
Copy link
Author

@asmecher

@Vitaliy-1
Copy link
Collaborator

Hi @mbarros64,

Have you explored where it's failing? It may be related to this issue related to block plugins

@prestesmatheus0
Copy link
Author

Hi @Vitaliy-1 , we found another way to make the plugin work, we verify if cache is empty, if is, we call the function that returns a list of kewords and put it on cache. And now, the code no more depends of _cacheMiss function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants