Disabling reinstate reviewer email template has no effect

[NateWr]

Describe the bug
The REVIEW_REINSTATE email template can be disabled from Settings > Workflow > Emails > Email Templates. However, this has no effect. The option to reinstate a reviewer still remains, and the editor can still choose whether or not to send the email when they reinstate the reviewer.

This is the case with other review emails. I have found this to be so with:

• REVIEW_REQUEST
• REVIEW_DECLINE
• REVIEW_CONFIRM (reviewer doesn't preview the email, but it seems to be sent either way)

To Reproduce
Steps to reproduce the behavior:

1. Go to Settings > Workflow > Emails > Email Templates.
2. Search for REVIEW_REINSTATE.
3. Expand the options for that template and disable the template.
4. Go to a submission with a review assignment already accepted or completed.
5. Cancel the review assignment.
6. Reinstate the review assignment.
7. See that the template is still there and the editor can choose to send the email or not.

What application are you using?
3.4 pre-release

Additional information
I think probably this email template shouldn't have the canDisable flag set. It doesn't make sense to disable emails that the editor can opt not to send.

[NateWr]

Yes, this probably needs a comprehensive review. For example, REVIEW_REQUEST can be disabled but not REVIEW_REQUEST_ATTACHED.

[Vitaliy-1]

REVIEW_REQUEST is checked if enabled in ReviewerForm::execute, i.e. when the mail is sent. But this doesn't make sense, it should be before form initialization.

[Vitaliy-1]

canDisable was moved from EmailTemplate to Mailable. Ensure this works as expected after email refactoring and new Mailable UI implementation.

[NateWr]

I'm investigated this as part of #5716. These fields won't be disable-able but they can be skipped in the UI. I consider it done, so closing.