From b2ffe654bfbaefea771fd66bd47dd4c7ff16075d Mon Sep 17 00:00:00 2001 From: Swen Mun Date: Thu, 21 May 2020 14:19:15 +0900 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Hong Minhee --- CHANGES.md | 2 +- Libplanet/Action/ActionEvaluation.cs | 2 +- Libplanet/Action/IAction.cs | 14 +++++++------- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index d661d20391..605647f67e 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -8,7 +8,7 @@ To be released. ### Backward-incompatible API changes - - Added `IAction.RenderError()` and `IAction.UnrenderError()`. + - Added `IAction.RenderError()` and `IAction.UnrenderError()` methods. [[#860], [#875]] ### Backward-incompatible network protocol changes diff --git a/Libplanet/Action/ActionEvaluation.cs b/Libplanet/Action/ActionEvaluation.cs index aa8759de22..da78d80331 100644 --- a/Libplanet/Action/ActionEvaluation.cs +++ b/Libplanet/Action/ActionEvaluation.cs @@ -24,7 +24,7 @@ public class ActionEvaluation /// evaluate . /// The result states that /// makes. - /// An exception that has raised during evaluating a given + /// An exception that has risen during evaluating a given /// . public ActionEvaluation( IAction action, diff --git a/Libplanet/Action/IAction.cs b/Libplanet/Action/IAction.cs index 910d5a87b0..d037ba3828 100644 --- a/Libplanet/Action/IAction.cs +++ b/Libplanet/Action/IAction.cs @@ -315,9 +315,9 @@ public interface IAction void Render(IActionContext context, IAccountStateDelta nextStates); /// - /// Does things that should be doen right after this action is - /// spread to the network or is “confirmed” (kind of) - /// by each peer node. + /// Does the similar things to , + /// except that this method is invoked when see cref="Execute(IActionContext)"/> method + /// has terminated with an exception. /// /// The equivalent context object to /// what method had received. @@ -353,11 +353,11 @@ public interface IAction void Unrender(IActionContext context, IAccountStateDelta nextStates); /// - /// Does things that should be undone right after this action is - /// invalidated (mostly due to a block which this action has belonged - /// to becoming considered a stale). + /// Does the similar things to , + /// except that this method is invoked when see cref="Execute(IActionContext)"/> method + /// has terminated with an exception. /// This method takes the equivalent arguments to - /// method. + /// method. /// /// /// The equivalent context object to