-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send BlockCommit
in BlocksMsg
#2558
Send BlockCommit
in BlocksMsg
#2558
Conversation
226f913
to
a2f5c3d
Compare
BlockCommit
in BlocksMsg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libplanet/Libplanet.Net/Swarm.BlockSync.cs
Lines 397 to 399 in 075a864
await foreach ( | |
(Block<T> block, BlockCommit commit, BoundPeer sourcePeer) | |
in completedBlocks.WithCancellation(cancellationToken)) |
libplanet/Libplanet.Net/Swarm.BlockSync.cs
Lines 542 to 548 in 075a864
// TODO : Block should be appended with commits. | |
workspace.Append( | |
deltaBlock, | |
null, | |
evaluateActions: false, | |
renderBlocks: renderBlocks, | |
renderActions: renderActions |
Append()
with BlockCommit
in CompleteBlockAsync()
is not implemented.
Nevermind, misread the comment. 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
byte[]
-typed .ToByteArray()
method and ImmutableArray<byte>
-typed .ByteArray
method looks confusing to me by its name. How about rename method that returning ImmutableArray
to ImmutableByteArray
or something?
I misused the word implemented. What I wanted to say was, the received |
@limebell |
Okay, we may discuss about that someday... |
5c6c9e5
to
4ac077b
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Closes #2551.