Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ByteArray instead of ToByteArray() for HashNode.ToBencodex() implementation #3922

Closed
greymistcube opened this issue Aug 14, 2024 · 0 comments · Fixed by #3924
Closed

Comments

@greymistcube
Copy link
Contributor

Usage of ToByteArray() results in copying the whole byte[] backing the ImmutableArray<byte> inside a HashDigest<SHA256>, once when calling HashDigest<SHA256>.ToByteArray() and once more when calling new Binary(byte[]). This results in an unnecessary usage of resources, both memory and cpu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant