Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block propagation is too slow #871

Closed
longfin opened this issue May 19, 2020 · 3 comments · Fixed by #879
Closed

Block propagation is too slow #871

longfin opened this issue May 19, 2020 · 3 comments · Fixed by #879
Assignees
@longfin
Labels
bug Something isn't working network Related to networking (Libplanet.Net)

Comments

@longfin
Copy link
Member

longfin commented May 19, 2020 •
edited
Loading

Blocks sometimes propagate after tens of seconds. if the target time for block creation is short(10~20s), this is a sufficient bottleneck.
@longfin longfin added bug Something isn't working network Related to networking (Libplanet.Net) labels May 19, 2020
@longfin longfin changed the title [WIP] Block propagation is too slow Block propagation is too slow May 19, 2020
@longfin longfin self-assigned this May 23, 2020
@longfin longfin linked a pull request May 23, 2020 that will close this issue
Improve block propagation performance #879
Merged
@longfin longfin mentioned this issue May 23, 2020
Merged
@longfin
Copy link
Member Author

longfin commented May 27, 2020

I guess another bottleneck seemed left. I'll look into this issue again.

@longfin longfin reopened this May 27, 2020
@longfin
Copy link
Member Author

longfin commented May 27, 2020

I found some clues from the old MacBook. it seemed to skip some block hashes and waiting for next block hashes.

This was referenced May 28, 2020
Closed
Merged
@longfin
Copy link
Member Author

longfin commented Jun 4, 2020

We've deployed #890 and reported symptom seems to be gone.

@longfin longfin closed this as completed Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@longfin longfin

Labels
bug Something isn't working network Related to networking (Libplanet.Net)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve block propagation performance longfin/libplanet.net
1 participant
@longfin