From a974850bb4231db6c85a5f02ce965d9b842688a1 Mon Sep 17 00:00:00 2001 From: Rohit Nayak Date: Thu, 12 Dec 2024 19:10:02 +0100 Subject: [PATCH] Address review comment: needed to reverse the bools passed because the variable name had changed from positive to negative intent ... Signed-off-by: Rohit Nayak --- go/vt/vtgate/vindexes/vschema.go | 2 +- go/vt/vtgate/vschema_manager.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/go/vt/vtgate/vindexes/vschema.go b/go/vt/vtgate/vindexes/vschema.go index 92bba97facf..9758917975a 100644 --- a/go/vt/vtgate/vindexes/vschema.go +++ b/go/vt/vtgate/vindexes/vschema.go @@ -356,7 +356,7 @@ func BuildVSchema(source *vschemapb.SrvVSchema, parser *sqlparser.Parser) (vsche buildKeyspaces(source, vschema, parser) // buildGlobalTables before buildReferences so that buildReferences can // resolve sources which reference global tables. - BuildGlobalTables(source, vschema, true) + BuildGlobalTables(source, vschema, false) buildReferences(source, vschema) buildRoutingRule(source, vschema, parser) buildShardRoutingRule(source, vschema) diff --git a/go/vt/vtgate/vschema_manager.go b/go/vt/vtgate/vschema_manager.go index a5167913a8c..9c0aaf1d186 100644 --- a/go/vt/vtgate/vschema_manager.go +++ b/go/vt/vtgate/vschema_manager.go @@ -197,7 +197,7 @@ func (vm *VSchemaManager) buildAndEnhanceVSchema(v *vschemapb.SrvVSchema) *vinde // Add tables from schema tracking into globally routable tables, if they are not already present. // We need to skip if already present, to handle the case where MoveTables has switched traffic // and removed the source vschema but not from the source database because user asked to --keep-data - vindexes.BuildGlobalTables(v, vschema, false) + vindexes.BuildGlobalTables(v, vschema, true) } return vschema }