support lazy constraints in plasmo #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
📢 Thoughts on this report? Let us know!. |
tso-martin
reviewed
Nov 23, 2023
| return MOI.get(graph.moi_backend, MOI.DualStatus()) | ||
| end | ||
|
|
||
| function JuMP.callback_value(cb_data, x::GenericVariableRef, graph::OptiGraph) |
There was a problem hiding this comment.
The retrieved callback values are not updated by the optimizer. The code below works:
function JuMP.callback_value(cb_data, x::GenericVariableRef, graph::OptiGraph)
var_index = graph.moi_backend.model_to_optimizer_map.var_map[x]
return MOI.get(
graph.moi_backend.optimizer,
MOI.CallbackVariablePrimal(cb_data),
var_index,
)
end
There was a problem hiding this comment.
thanks @tso-martin. I will make a new PR to fix this (with tests to boot).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets basic lazy constraint callbacks working in Plasmo.jl. This is meant to address #89.