Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate ClassicActorSystemProvider binding when using with Play 2.8.3 #317

Open
octonato opened this issue Oct 30, 2020 · 2 comments
Open

Comments

@octonato
Copy link
Contributor

octonato commented Oct 30, 2020

Play 2.8.3 provides already a binding for akka.actor.ClassicActorSystemProvider which causes the following error:

A binding to akka.actor.ClassicActorSystemProvider was already configured at play.grpc.ClassicActorsystemProviderModule.<init>(ClassicActorsystemProviderModule.scala:13):
[error] Binding(interface akka.actor.ClassicActorSystemProvider to ProviderConstructionTarget(class play.api.libs.concurrent.ActorSystemProvider)) (via modules: com.google.inject.util.Modules$OverrideModule -> play.api.inject.guice.GuiceableModuleConversions$$anon$4).

Only affects Play users (Java and Scala) using Guice.

Workaround

Users upgrading to Play 2.8.3 can disable the play-grpc Guice module providing the binding with:

play.modules.disabled += "play.grpc.ClassicActorsystemProviderModule"

See PR #309

@octonato octonato changed the title Duplicate Guice binding when using with Play 2.8.3 Duplicate ClassicActorSystemProvider binding when using with Play 2.8.3 Oct 30, 2020
@ignasi35
Copy link
Member

@octonato IIUC this is fixed, right? Can we close the issue already?

@bmo-at
Copy link

bmo-at commented Oct 18, 2021

As far as I can tell the issue persists in Play 2.8.8/Play-grpc 1.1.1 when using guice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants