Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: with custom DNS/name resolver #407

Open
PAStheLoD opened this issue Oct 14, 2019 · 0 comments
Open

Feature request: with custom DNS/name resolver #407

PAStheLoD opened this issue Oct 14, 2019 · 0 comments

Comments

@PAStheLoD
Copy link

Play WS Version (2.5.x / etc)

N/A

API (Scala / Java / Neither / Both)

Scala (or Both)

Operating System (Ubuntu 15.10 / MacOS 10.10 / Windows 10)

N/A

JDK (Oracle 1.8.0_72, OpenJDK 1.8.x, Azul Zing)

N/A

Library Dependencies

AHC (and/or Akka HTTP, though that effort seems rather severely stalled)

Expected Behavior

Currently there's no way to sanely pass in a different name resolver, instead one has to change one field (the static DEFAULT_NAME_RESOLVER in RequestBuilderBase) in the shaded AHC package.

Also simply documenting it would probably help a bit, eg. something like:

def monkeyPatchPlayWsShadedAhcRequestBuilderBase(): Unit = {
    play.shaded.ahc.org.asynchttpclient.RequestBuilderBase.DEFAULT_NAME_RESOLVER =
      new YourSpecialResolver(ImmediateEventExecutor.INSTANCE)
}
@settings settings bot removed the triage label Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant