Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source code for shaded jars are not properly published along with the shaded jars #683

Open
jhooda opened this issue May 20, 2022 · 0 comments

Comments

@jhooda
Copy link

jhooda commented May 20, 2022

The problem is when attaching debugger with a running process using any shaded library. The non-shaded source code won't bind with the shaded classes that belong to the shaded packages such as

package play.shaded.ahc.io.netty.channel.nio;
...
public abstract class AbstractNioChannel extends AbstractChannel {

The source code is still 266 bytes, see, https://repo1.maven.org/maven2/com/typesafe/play/shaded-asynchttpclient/2.1.3/

So any plan to correctly publish shaded sources?

A workaround in case someone needs it

$ cd netty
$ mkdir -p transport/src/main/java/play/shaded/ahc
$ cp -a transport/src/main/java/io transport/src/main/java/play/shaded/ahc/.
$ find transport/src/main/java/play/shaded/ahc -name "*.java" -exec sed -i 's#package io\.#package play.shaded.ahc.io.#' {} \; -exec sed -i 's#import io\.#import play.shaded.ahc.io.#' {} \; -exec sed -i 's#import static io\.#import static play.shaded.ahc.io.#' {} \;

Originally posted by @jhooda in #85 (comment)

@jhooda jhooda changed the title The problem is when attaching debugger with a running process using any shaded library. The non-shaded source code won't bind with the shaded classes that belong to the shaded packages such as Source code for all shaded jars are not properly published along with the shaded jars May 20, 2022
@jhooda jhooda changed the title Source code for all shaded jars are not properly published along with the shaded jars Source code for shaded jars are not properly published along with the shaded jars May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant