Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expect.soft assertions only #60

Closed
unlikelyzero opened this issue Jun 14, 2022 · 4 comments · Fixed by #118
Closed

Expect.soft assertions only #60

unlikelyzero opened this issue Jun 14, 2022 · 4 comments · Fixed by #118
Assignees
Labels
enhancement New feature or request

Comments

@unlikelyzero
Copy link

It would be great to have a rule to enforce expect.soft assertions. I've found that they've been a great way to isolate failure in tests but find it difficult to keep track of them during code reviews.

@mskelton
Copy link
Member

Hmm. @mxschmitt what do you think? Feels like a pretty odd rule to enforce IMO, in my experience soft assertions are a infrequently used feature that comes in handy in a few instances, but certainly not everywhere.

@mxschmitt
Copy link
Collaborator

We can definitely have it, but disabled by default.

A good thing which I might see is that at the end of your test execution you might have more information to fix your test instead of just one assertion which failed. But this sounds also like a source of a lot of redundant information which gets added.

@unlikelyzero
Copy link
Author

@mskelton we're encouraging folks to write "longer" tests given that most of our test duration is spent setting up certain contexts and we're recording the tracefiles which give "pin point accuracy" for test failure.

@mskelton mskelton changed the title [Enhancement] Expect.soft assertions only Expect.soft assertions only Aug 21, 2022
@mskelton mskelton added the enhancement New feature or request label Aug 21, 2022
@mskelton mskelton self-assigned this Jan 15, 2023
@mskelton
Copy link
Member

Been a while, but I have a PR to fix this finally 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants