You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, thanks for this library, it saved my life when I was desperate to find an issue with a Playwright test. Good job, really.
Here is a proposal for a possible improvement:
The expect.poll method can be used to query arbitrary data (not necessarily locators) and in this case, any method called after expect should probably raise a warning.
For instance:
expect.poll(()=>{/* some code */}).toContain('foo');
should probably raise an eslint error about a missing await.
Right now, it is not raising an error, because toContain is not in the list of checked methods for expect.
The text was updated successfully, but these errors were encountered:
Hey!
First of all, thanks for this library, it saved my life when I was desperate to find an issue with a Playwright test. Good job, really.
Here is a proposal for a possible improvement:
The
expect.poll
method can be used to query arbitrary data (not necessarily locators) and in this case, any method called afterexpect
should probably raise a warning.For instance:
should probably raise an eslint error about a missing
await
.Right now, it is not raising an error, because
toContain
is not in the list of checked methods forexpect
.The text was updated successfully, but these errors were encountered: