From 777cc0c9747ab9e734588b888ee0e695145002b9 Mon Sep 17 00:00:00 2001
From: ionlizarazu <ilizarazu@codesyntax.com>
Date: Tue, 24 Mar 2020 16:24:06 +0100
Subject: [PATCH] add a label to the select all checkbox and to each of the
 items in the table to make the table more accessible

---
 mockup/patterns/structure/templates/table.xml    | 2 +-
 mockup/patterns/structure/templates/tablerow.xml | 2 +-
 news/957.bugfix                                  | 3 +++
 3 files changed, 5 insertions(+), 2 deletions(-)
 create mode 100644 news/957.bugfix

diff --git a/mockup/patterns/structure/templates/table.xml b/mockup/patterns/structure/templates/table.xml
index 9f7fb578d..e018bad02 100644
--- a/mockup/patterns/structure/templates/table.xml
+++ b/mockup/patterns/structure/templates/table.xml
@@ -18,7 +18,7 @@
        data-pat-datatables="<%- datatables_options %>">
   <thead>
     <tr>
-      <th class="selection"><input type="checkbox" class="select-all" /></th>
+      <th class="selection"><label for="selectAllInputCheckbox" class="hiddenStructure" aria-label="<%- _t('Select all') %>"><%- _t('Select all') %></label><input id="selectAllInputCheckbox" type="checkbox" class="select-all" /></th>
       <th class="title"><%- _t('Title') %></th>
       <% _.each(activeColumns, function(column){ %>
         <% if(column !== 'Description' && _.has(availableColumns, column)) { %>
diff --git a/mockup/patterns/structure/templates/tablerow.xml b/mockup/patterns/structure/templates/tablerow.xml
index 0eba85e9d..a564ea6ed 100644
--- a/mockup/patterns/structure/templates/tablerow.xml
+++ b/mockup/patterns/structure/templates/tablerow.xml
@@ -1,4 +1,4 @@
-<td class="selection" data-order="<%- attributes['_sort'] %>"><input type="checkbox" <% if(selected){ %> checked="checked" <% } %>/></td>
+<td class="selection" data-order="<%- attributes['_sort'] %>"><label for="select<%- attributes['_sort'] %>InputCheckbox" class="hiddenStructure" aria-label="<%- _t('Select') %>"><%- _t('Select') %></label><input id="select<%- attributes['_sort'] %>InputCheckbox" <% if(selected){ %> checked="checked" <% } %> type="checkbox"/></td>
 
 <td class="title">
   <div class="pull-left">
diff --git a/news/957.bugfix b/news/957.bugfix
new file mode 100644
index 000000000..86e95d257
--- /dev/null
+++ b/news/957.bugfix
@@ -0,0 +1,3 @@
+add a label to the select all checkbox and to each of the items in the table to make the table more accessible
+[erral & ionlizarazu]
+