Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate "I'm logged in as..."? #67

Open
tisto opened this issue Mar 28, 2017 · 1 comment
Open

Deprecate "I'm logged in as..."? #67

tisto opened this issue Mar 28, 2017 · 1 comment

Comments

@tisto
Copy link
Sponsor Member

tisto commented Mar 28, 2017

We currently have two ways of defining a precondition for a logged in user:

I'm logged in as a 'Site Administrator'

or

a logged in site administrator

Both keywords use past tense, which is considered best practice for GIVEN keywords in BDD. Though, the "I do something" is usually reserved for WHEN keywords to indicate an action of a user. Therefore if we want to use this keyword in GIVEN, we should stick to the second option and deprecate the first option to avoid confusion. What do you think @datakurre?

@datakurre
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants