From 278ca6c387ba60f98849a76dea2233113abda5ba Mon Sep 17 00:00:00 2001 From: Steve Piercy Date: Sun, 3 Nov 2024 02:28:51 -0800 Subject: [PATCH] Fix display of nvm version when installing it for Contributing to Volto. (#6460) --- docs/source/conf.py | 19 +++++++++---------- docs/source/contributing/install-nvm.md | 2 +- packages/volto/news/6460.documentation | 1 + 3 files changed, 11 insertions(+), 11 deletions(-) create mode 100644 packages/volto/news/6460.documentation diff --git a/docs/source/conf.py b/docs/source/conf.py index 360ce22c48..8619c2a428 100644 --- a/docs/source/conf.py +++ b/docs/source/conf.py @@ -289,20 +289,19 @@ # An extension that allows replacements for code blocks that # are not supported in `rst_epilog` or other substitutions. # https://stackoverflow.com/a/56328457/2214933 -def source_replace(app, docname, source): - result = source[0] - for key in app.config.source_replacements: - result = result.replace(key, app.config.source_replacements[key]) - source[0] = result +# def source_replace(app, docname, source): +# result = source[0] +# for key in app.config.source_replacements: +# result = result.replace(key, app.config.source_replacements[key]) +# source[0] = result # Dict of replacements. -source_replacements = { - "{NVM_VERSION}": "0.39.5", -} +# source_replacements = { +# } def setup(app): - app.add_config_value("source_replacements", {}, True) - app.connect("source-read", source_replace) + # app.add_config_value("source_replacements", {}, True) + # app.connect("source-read", source_replace) app.add_config_value("context", "volto", "env") diff --git a/docs/source/contributing/install-nvm.md b/docs/source/contributing/install-nvm.md index 93cb8c36ce..79209895c4 100644 --- a/docs/source/contributing/install-nvm.md +++ b/docs/source/contributing/install-nvm.md @@ -15,7 +15,7 @@ For the `fish` shell, see [`nvm.fish`](https://github.com/jorgebucaran/nvm.fish) 2. Download and run the `nvm` install and update script, and pipe it into `bash`. ```shell - curl -o- https://raw.githubusercontent.com/creationix/nvm/v{NVM_VERSION}/install.sh | bash + curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.39.5/install.sh | bash ``` 3. Source your profile. diff --git a/packages/volto/news/6460.documentation b/packages/volto/news/6460.documentation new file mode 100644 index 0000000000..f3c2c72632 --- /dev/null +++ b/packages/volto/news/6460.documentation @@ -0,0 +1 @@ +Fix display of nvm version when installing it for Contributing to Volto. @stevepiercy