Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definition template for carpool contract #3

Open
pmiklos opened this issue Jan 20, 2019 · 1 comment
Open

Add definition template for carpool contract #3

pmiklos opened this issue Jan 20, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@pmiklos
Copy link
Owner

pmiklos commented Jan 20, 2019

The carpool contract is relatively big and it costs about 1500 bytes when spending the funds from the contract due to the inclusion of the contract definition. The introduction of definition template would greatly reduce the costs since it the actual contract would only refer to the template hash and the actual parameters.

The template has 4 parameters:

  • carpool oracle address
  • carpool payout processor address
  • driver's payout address
  • passenger's refund address

The carpool oracle address and payout processor address are relatively stable and not expected to change, so they could be hard-coded into the template to further save cost.

@pmiklos
Copy link
Owner Author

pmiklos commented Feb 2, 2019

the GUI wallet cannot handle smart contracts with definition template unfortunately as of today, so when a user receives such a contract, the payment request is shown, but clicking on it does nothing.

@pmiklos pmiklos added the enhancement New feature or request label Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant