-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when trying to save effect with amplifier >127 to NBT #1072
Comments
That’s sure, you are not’ using the last version. |
I swear, if anyone could read backtraces... |
I have the same issue, but with the duration ones also. It does not have the input check for IntTag's range, so I ended up don't know where is my plugin's fault. Now whenever the server do auto-save, my server pop-up 2 of these errors:
|
Issue description Steps to reproduce the issue Users joining server cause crash, full reason unknown. PocketMine-MP version: 1.6.2dev #0 [Protocol 113; API 3.0.0-ALPHA5]
|
Was likely the plugin using $speed->setDuration(PHP_INT_MAX); causing the issue. |
Why the value of PHP_INT_MAX is different? I think with the level of knowing how to use PHP_INT_MAX, no one is gonna add some value to PHP_INT_MAX, do they ? |
PHP_INT_MAX is PHP's maximum supported int value on that architecture. IntTag stores a 32-bit integer. When PHP is running on a 64-bit system, PHP_INT_MAX is outside the bounds of a 32-bit integer. |
One way to fix this would be using an if statement. |
@Muqsit the types are correct, but they exceed the bounds because they are unsigned, whereas TAG_* values are always supposed to be signed. |
@dktapps Oh, makes sense now. |
also interesting |
Issue description
server crashing randomlySteps to reproduce the issue
OS and versions
Plugins
If the issue is not reproducible without plugins:
Crashdump, backtrace or other files
https://pastebin.com/bXjgXTMX
https://pastebin.com/uB5qqeVi
The text was updated successfully, but these errors were encountered: