From 54e2c9e62b243e0e7ddfc9f88f3284c5b75e6fd4 Mon Sep 17 00:00:00 2001
From: vis-prime <vishals1030@gmail.com>
Date: Tue, 5 Dec 2023 10:18:13 +0530
Subject: [PATCH] fix: restore old shaderMaterial

---
 src/core/shaderMaterial.ts | 93 ++++++++++++++++++++------------------
 1 file changed, 48 insertions(+), 45 deletions(-)

diff --git a/src/core/shaderMaterial.ts b/src/core/shaderMaterial.ts
index cbbadce..02c0c76 100644
--- a/src/core/shaderMaterial.ts
+++ b/src/core/shaderMaterial.ts
@@ -1,58 +1,61 @@
 import * as THREE from 'three'
 
-export function shaderMaterial(
-  uniforms: {
-    [name: string]:
-      | THREE.CubeTexture
-      | THREE.Texture
-      | Int32Array
-      | Float32Array
-      | THREE.Matrix4
-      | THREE.Matrix3
-      | THREE.Quaternion
-      | THREE.Vector4
-      | THREE.Vector3
-      | THREE.Vector2
-      | THREE.Color
-      | number
-      | boolean
-      | Array<any>
-      | null
-  },
+type UniformValue =
+  | THREE.CubeTexture
+  | THREE.Texture
+  | Int32Array
+  | Float32Array
+  | THREE.Matrix4
+  | THREE.Matrix3
+  | THREE.Quaternion
+  | THREE.Vector4
+  | THREE.Vector3
+  | THREE.Vector2
+  | THREE.Color
+  | number
+  | boolean
+  | Array<any>
+  | null
+
+type UniformProps = { [name: string]: UniformValue }
+
+type ShaderMaterialInstance<TProps extends UniformProps> = THREE.ShaderMaterial & TProps
+
+type ShaderMaterialParameters<TProps extends UniformProps> = THREE.ShaderMaterialParameters & Partial<TProps>
+
+type ShaderMaterial<TProps extends UniformProps> = (new (
+  parameters?: ShaderMaterialParameters<TProps>
+) => ShaderMaterialInstance<TProps>) & { key: string }
+
+export function shaderMaterial<TProps extends UniformProps>(
+  uniforms: TProps,
   vertexShader: string,
   fragmentShader: string,
-  onInit?: (material?: THREE.ShaderMaterial) => void
+  onInit?: (material: ShaderMaterialInstance<TProps>) => void
 ) {
-  const material = class extends THREE.ShaderMaterial {
-    public key: string = ''
-    constructor(parameters = {}) {
-      const entries = Object.entries(uniforms)
-      // Create uniforms and shaders
-      super({
-        uniforms: entries.reduce((acc, [name, value]) => {
-          const uniform = THREE.UniformsUtils.clone({ [name]: { value } })
-          return {
-            ...acc,
-            ...uniform,
-          }
-        }, {}),
-        vertexShader,
-        fragmentShader,
-      })
-      // Create getter/setters
-      entries.forEach(([name]) =>
+  const entries = Object.entries(uniforms)
+  const uniformDefs = Object.fromEntries(entries.map(([name, value]) => [name, { value }])) as {
+    [K in keyof TProps]: { value: TProps[K] }
+  }
+
+  class Material extends THREE.ShaderMaterial {
+    static key = THREE.MathUtils.generateUUID()
+
+    constructor(parameters?: ShaderMaterialParameters<TProps>) {
+      super({ uniforms: uniformDefs, vertexShader, fragmentShader })
+
+      for (const [name] of entries) {
         Object.defineProperty(this, name, {
           get: () => this.uniforms[name].value,
           set: (v) => (this.uniforms[name].value = v),
         })
-      )
+      }
 
-      // Assign parameters, this might include uniforms
       Object.assign(this, parameters)
-      // Call onInit
-      if (onInit) onInit(this)
+
+      onInit?.(this as unknown as ShaderMaterialInstance<TProps>)
     }
-  } as unknown as typeof THREE.ShaderMaterial & { key: string }
-  material.key = THREE.MathUtils.generateUUID()
-  return material
+  }
+
+  return Material as ShaderMaterial<TProps>
 }