Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: spriteanimator manual progression #1669

Merged
merged 22 commits into from
Jan 5, 2024

Conversation

netgfx
Copy link
Contributor

@netgfx netgfx commented Sep 29, 2023

Why

Added functionality for SpriteAnimator to play via manual progression like ScrollControls.
Added functionality to play sprite backwards

What

Converted the SpriteAnimator to a forwardRef, to allow React.useImperativeHandle which can allow other properties to be added in the future and be accessible via useSpriteAnimator() hook
This allowed me to add the functionality for manual progression of the animation

Checklist

  • [ x] Documentation updated (example)
  • Storybook entry added (example)
  • [x ] Ready to be merged

@vercel
Copy link

vercel bot commented Sep 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2023 0:40am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 29, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1706306:

Sandbox Source
cocky-alex-hmjd44 Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@netgfx netgfx merged commit aa2dd0f into pmndrs:master Jan 5, 2024
4 checks passed
Copy link

github-actions bot commented Jan 5, 2024

🎉 This PR is included in version 9.93.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant