Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support for variable sized sprites #1678

Merged

Conversation

netgfx
Copy link
Contributor

@netgfx netgfx commented Oct 7, 2023

Why

SpriteAnimator didn't not support variable sized sprites within the same spritesheet

What

it now pulls the current frame set when calculating aspect ratio so it recalculates the scale when the current frame set changes. This only affects json hash spritesheets with multiple animations on the same spritesheet, with a different size for each animation sequence.

Checklist

  • Documentation updated (example)
  • Storybook entry added (example)
  • [x ] Ready to be merged

@vercel
Copy link

vercel bot commented Oct 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2023 11:12am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 7, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ba0fcea:

Sandbox Source
cool-cookies-rgnhvm Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@drcmda drcmda merged commit bc12fe0 into pmndrs:master Oct 9, 2023
4 checks passed
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

🎉 This PR is included in version 9.87.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

netgfx added a commit that referenced this pull request Jan 5, 2024
* feat: added optional Sprite or Plane geometry for SpriteAnimator

* feat: added manual progression to spriteanimator

* fix: support for variable sized sprites

* fix: to come in-sync with #1678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants