-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support for variable sized sprites #1678
Merged
drcmda
merged 8 commits into
pmndrs:master
from
netgfx:fix/spriteanimator-support-variable-size-sprites
Oct 9, 2023
Merged
fix: support for variable sized sprites #1678
drcmda
merged 8 commits into
pmndrs:master
from
netgfx:fix/spriteanimator-support-variable-size-sprites
Oct 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ba0fcea:
|
netgfx
added a commit
to netgfx/drei
that referenced
this pull request
Oct 7, 2023
🎉 This PR is included in version 9.87.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
netgfx
added a commit
that referenced
this pull request
Jan 5, 2024
* feat: added optional Sprite or Plane geometry for SpriteAnimator * feat: added manual progression to spriteanimator * fix: support for variable sized sprites * fix: to come in-sync with #1678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
SpriteAnimator didn't not support variable sized sprites within the same spritesheet
What
it now pulls the current frame set when calculating aspect ratio so it recalculates the scale when the current frame set changes. This only affects json hash spritesheets with multiple animations on the same spritesheet, with a different size for each animation sequence.
Checklist