feat: add ScreenSizer #1760
Merged
feat: add ScreenSizer #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a90220c:
|
|
🎉 This PR is included in version 9.97.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been using this for a while and though others may find it useful too. The heavy work was done already by
PivotControls, so I just wrapped the logic in a separated component for re-usability.Why
Is a common use-case to need a ThreeJS object to hold roughly the same dimensions in screen space no matter how far from the camera it is. This is tipically required when building custom gizmos, where the gizmos holds the same size in the screen as you zoom in/out.
What
Add
ScreenSizercomponent to render objects that roughly hold the same size independently of camera distance.Move
calculateScaleFactorfrom./src/web/pivotControls/index.tsxto./src/core/calculateScaleFactoras it doesn't have web dependencies and is a dependency ofScreenSizer.Checklist
Demo
Link
screen-sizer.mp4